Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8354#discussion_r42454496
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala 
---
    @@ -196,14 +194,8 @@ private[hive] object HiveShim {
           if (instance != null) {
             instance.asInstanceOf[UDFType]
           } else {
    -        val func = Utils.getContextOrSparkClassLoader
    +        Utils.getContextOrSparkClassLoader
               .loadClass(functionClassName).newInstance.asInstanceOf[UDFType]
    -        if (!func.isInstanceOf[UDF]) {
    --- End diff --
    
    Even if the functions weren't stateless, I don't think that's an issue 
because each task will get its own separate deserialized copy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to