Github user rick-ibm commented on the pull request:
https://github.com/apache/spark/pull/9202#issuecomment-150267546
Thanks for the review comments, Sean.
I did not polish the Java code in SqlIdentifierUtil, and I didn't translate
it into Scala. This was in the interests of stability (see the header comment
on my pull request above). The code came from Derby, where it has been proven
by two decades of use in production applications. But I am happy to re-write it
in Scala if you think that the benefits outweigh the risk of introducing bugs.
Concerning JdbcDialects.vetSqlIdentifier(), thanks for the suggestion about
using a case class. That does sound like a better solution.
Thanks,
-Rick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
