Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9127#discussion_r42895096
  
    --- Diff: 
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
 ---
    @@ -49,18 +48,25 @@ import org.apache.spark.executor.ShuffleWriteMetrics
      * writes. This may lead to a performance regression compared to the 
normal case of using the
      * non-spilling AppendOnlyMap.
      */
    -@DeveloperApi
    --- End diff --
    
    Yeah. The issue is that Spillable now requires a TaskMemoryManager, which 
won't be available on the driver. I'm pretty sure that this class was never 
intended to be DeveloperAPI'd. If you feel strongly that we shouldn't break 
this, I can add a compatibility test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to