Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9127#discussion_r42898067
--- Diff: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
---
@@ -115,6 +205,35 @@ private[spark] abstract class MemoryManager extends
Logging {
}
/**
+ * Release numBytes of execution memory belonging to the given task.
+ */
+ final def releaseExecutionMemory(numBytes: Long, taskAttemptId: Long):
Unit = synchronized {
+ val curMem = memoryConsumptionForTask.getOrElse(taskAttemptId, 0L)
+ if (curMem < numBytes) {
+ throw new SparkException(
+ s"Internal error: release called on $numBytes bytes but task only
has $curMem")
+ }
+ if (memoryConsumptionForTask.contains(taskAttemptId)) {
+ memoryConsumptionForTask(taskAttemptId) -= numBytes
+ if (memoryConsumptionForTask(taskAttemptId) <= 0) {
+ memoryConsumptionForTask.remove(taskAttemptId)
+ }
+ releaseExecutionMemory(numBytes)
+ }
+ notifyAll() // Notify waiters in tryToAcquire that memory has been
freed
--- End diff --
outdated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
