Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9254#discussion_r42895844
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -215,7 +216,7 @@ private[netty] class Outbox(nettyEnv: NettyRpcEnv, val
address: RpcAddress) {
// update messages and it's safe to just drain the queue.
var message = messages.poll()
--- End diff --
But why? What's being optimized here? It's such a rare occurrence that it's
better to pay the allocation cost when it happens than waste the memory to keep
the singleton around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
