Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9254#discussion_r42896850
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Outbox.scala ---
@@ -215,7 +216,7 @@ private[netty] class Outbox(nettyEnv: NettyRpcEnv, val
address: RpcAddress) {
// update messages and it's safe to just drain the queue.
var message = messages.poll()
--- End diff --
I doubt there will be many messages in the outbox at a time. This code
mostly fixes a race during initialization of the RPC channel, later the outbox
would be mostly a bypass. #9210 even bypasses the outbox altogether in a lot of
cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
