Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9127#issuecomment-150667335 The high level refactoring looks good. Once you make it pass tests and address the remaining comments (all of which are minor) I will merge this. Thanks for all your work on this @JoshRosen.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org