Github user zhzhan commented on a diff in the pull request: https://github.com/apache/spark/pull/9232#discussion_r43204781 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -142,6 +145,97 @@ class YarnSparkHadoopUtil extends SparkHadoopUtil { val containerIdString = System.getenv(ApplicationConstants.Environment.CONTAINER_ID.name()) ConverterUtils.toContainerId(containerIdString) } + + /** + * Obtains token for the Hive metastore, using the current user as the principal. + * Some exceptions are caught and downgraded to a log message. + * @param conf hadoop configuration; the Hive configuration will be based on this + * @return a token, or `None` if there's no need for a token (no metastore URI or principal + * in the config), or if a binding exception was caught and downgraded. + */ + def obtainTokenForHiveMetastore(conf: Configuration): Option[Token[DelegationTokenIdentifier]] = { + try { + obtainTokenForHiveMetastoreInner(conf, UserGroupInformation.getCurrentUser().getUserName) + } catch { + case e: Exception => { + handleTokenIntrospectionFailure("Hive", e) + None + } + } + } + + /** + * Handle failures to obtain a token through introspection. Failures to load the class are + * not treated as errors: anything else is. + * @param service service name for error messages + * @param thrown exception caught + * @throws Exception if the `thrown` exception isn't one that is to be ignored + */ + private[yarn] def handleTokenIntrospectionFailure(service: String, thrown: Throwable): Unit = { + thrown match { + case e: ClassNotFoundException => + logInfo(s"$service class not found $e") + logDebug("Hive Class not found", e) + case t: Throwable => { + throw t --- End diff -- Here the exception is thrown. I know swallow the exception is bad, but what happen if the user does not want to access the hive metastore but want to use spark even if token cannot be acquired?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org