Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9232#discussion_r43233453 --- Diff: yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala --- @@ -245,4 +247,55 @@ class YarnSparkHadoopUtilSuite extends SparkFunSuite with Matchers with Logging System.clearProperty("SPARK_YARN_MODE") } } + + test("Obtain tokens For HiveMetastore") { + val hadoopConf = new Configuration() + hadoopConf.set("hive.metastore.kerberos.principal", "bob") + // thrift picks up on port 0 and bails out, without trying to talk to endpoint + hadoopConf.set("hive.metastore.uris", "http://localhost:0") + val util = new YarnSparkHadoopUtil + val e = intercept[InvocationTargetException] { + util.obtainTokenForHiveMetastoreInner(hadoopConf, "alice") + } + assertNestedHiveException(e) + // expect exception trapping code to unwind this hive-side exception + assertNestedHiveException(intercept[InvocationTargetException] { + util.obtainTokenForHiveMetastore(hadoopConf) + }) + } + + def assertNestedHiveException(e: InvocationTargetException): Throwable = { + val inner = e.getCause + if (inner == null) { + fail("No inner cause", e) + } + if (!inner.isInstanceOf[HiveException]) { + fail(s"Not a hive exception", inner) + } + inner + } + + test("handleTokenIntrospectionFailure") { + val util = new YarnSparkHadoopUtil + // downgraded exceptions + util.handleTokenIntrospectionFailure("hive", new ClassNotFoundException("cnfe")) --- End diff -- Following my previous comment, you could get rid of this whole test case if you just do exception handling in the caller method. If you really want to test that CNFE is ignored, you could use Mockito's `spy` to mock `obtainTokenForHiveMetastoreInner` and make it throw a CNFE. The other tests here are not really that interesting anymore.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org