Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9477#discussion_r43983047
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -32,24 +37,39 @@ public int compare(PackedRecordPointer left,
PackedRecordPointer right) {
}
private static final SortComparator SORT_COMPARATOR = new
SortComparator();
+ private final MemoryConsumer consumer;
+ private final TaskMemoryManager memoryManager;
--- End diff --
Mind calling this `taskMemoryManager` so that it's clear that's what it is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
