Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9477#discussion_r43983708
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -32,24 +37,39 @@ public int compare(PackedRecordPointer left,
PackedRecordPointer right) {
}
private static final SortComparator SORT_COMPARATOR = new
SortComparator();
+ private final MemoryConsumer consumer;
+ private final TaskMemoryManager memoryManager;
+
/**
* An array of record pointers and partition ids that have been encoded
by
* {@link PackedRecordPointer}. The sort operates on this array instead
of directly manipulating
* records.
*/
- private long[] array;
+ private LongArray array;
/**
* The position in the pointer array where new records can be inserted.
*/
private int pos = 0;
- public ShuffleInMemorySorter(int initialSize) {
+ public ShuffleInMemorySorter(
+ MemoryConsumer consumer,
+ TaskMemoryManager memoryManager,
--- End diff --
Why does this class take both a `memoryManager` _and_ a consumer? Why not
pass it just the consumer and use methods of the `consumer` to do the
allocation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
