Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/9421#issuecomment-154246737
Overall there are a few majors suggestions.
- To test for the timer stuff in `KinesisCheckpointer`, its best to
refactor `KinesisCheckpointer` to use `streaming.util.RecurringTimer` instead
of scheduled executor service, so that it can be tested with manual clock.
- Some refactoring of the KinesisCheckpointer internal logic to remove
unnecessary options, and to simplify shutdown logic.
- Some minor test refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
