Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9421#discussion_r44235736
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala
---
@@ -135,18 +105,17 @@ private[kinesis] class KinesisRecordProcessor[T](
*/
override def shutdown(checkpointer: IRecordProcessorCheckpointer,
reason: ShutdownReason) {
logInfo(s"Shutdown: Shutting down workerId $workerId with reason
$reason")
- reason match {
+ // We want to return a checkpointer based on the shutdown cause. If we
want to terminate,
+ // then we want to use the given checkpointer to checkpoint one last
time. In other cases,
+ // we return a `null` so that we don't checkpoint one last time.
+ val cp: IRecordProcessorCheckpointer = reason match {
--- End diff --
Can this code be just simplified to
```
reason match {
case ShutdownReason.TERMINATE => receiver.removeCheckpointer(shardId, cp)
case _ => receiver.removeCheckpointer(shardId, null) // return null so
that we don't checkpoint
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
