Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9409#discussion_r44210935
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
 ---
    @@ -419,3 +419,30 @@ case class Greatest(children: Seq[Expression]) extends 
Expression {
         """
       }
     }
    +
    +/** Operator that drops a row when it contains any nulls. */
    +case class DropAnyNull(child: Expression) extends UnaryExpression {
    +  override def nullable: Boolean = true
    +  override def dataType: DataType = child.dataType
    +
    +  protected override def nullSafeEval(input: Any): InternalRow = {
    +    val row = input.asInstanceOf[InternalRow]
    --- End diff --
    
    So it turns out this is actually correct. The ```eval``` method of 
```UnaryExpression``` will call ```eval``` on the ```child``` expression and 
pass the result on the ```nullSafeEval``` method if it's not null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to