Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9409#discussion_r44216923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala
---
@@ -54,10 +54,14 @@ object Utils {
mode = aggregate.Complete,
isDistinct = false)
- // We do not support multiple COUNT DISTINCT columns for now.
- case expressions.CountDistinct(children) if children.length == 1 =>
+ case expressions.CountDistinct(children) =>
+ val child = if (children.size > 1) {
+ DropAnyNull(CreateStruct(children))
--- End diff --
Added (proper) StructType checking.
Do you want me to also start throwing ```AnalysisError```'s?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
