Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/9421#discussion_r44235797 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -217,6 +226,29 @@ private[kinesis] class KinesisReceiver[T]( } /** + * Set the checkpointer that will be used to checkpoint sequence numbers to DynamoDB for the + * given shardId. + */ + private[kinesis] def setCheckpointer( --- End diff -- The whole class is `private[kinesis]`. Its not a big deal really, but it causes a bit of confusion while reading the code, as if this the whole class is public. Please be aware of such issues elsewhere.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org