Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44350703
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -525,21 +526,15 @@ class Analyzer(
case u @ UnresolvedFunction(name, children, isDistinct) =>
withPosition(u) {
registry.lookupFunction(name, children) match {
+ // DISTINCT is not meaningful for a Max or a Min.
+ case max: Max if isDistinct =>
+ AggregateExpression(max, Complete, isDistinct = false)
+ case min: Min if isDistinct =>
+ AggregateExpression(min, Complete, isDistinct = false)
// We get an aggregate function built based on
AggregateFunction2 interface.
// So, we wrap it in AggregateExpression2.
--- End diff --
This is a little out of date.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
