Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -141,6 +146,12 @@ sealed abstract class AggregateFunction2 extends
Expression with ImplicitCastInp
override protected def genCode(ctx: CodeGenContext, ev:
GeneratedExpressionCode): String =
throw new UnsupportedOperationException(s"Cannot evaluate expression:
$this")
+
+ def toAggregateExpression(): AggregateExpression =
toAggregateExpression(isDistinct = false)
--- End diff --
Can you add some scaladoc here about why we need to do this wrapping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
