Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44355961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -108,7 +109,16 @@ trait CheckAnalysis {
case Aggregate(groupingExprs, aggregateExprs, child) =>
def checkValidAggregateExpression(expr: Expression): Unit =
expr match {
- case _: AggregateExpression => // OK
+ case aggExpr: AggregateExpression =>
+ // TODO: Is it possible that the child of a agg function
is another
+ // agg function?
+ aggExpr.aggregateFunction.children.foreach {
+ case child if !child.deterministic =>
+ failAnalysis(
+ s"nondeterministic expression ${expr.prettyString}
are not allowed " +
+ s"in grouping expression.")
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
