GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/9761
[SPARK-8658] [SQL] [FOLLOW-UP] AttributeReference's equals method compares all the members Based on the comment of @cloud-fan , update the AttributeReference's hashCode function by including the hashCode of the other attributes including name, nullable and qualifiers. Here, I am not 100% sure if we should include name in the hashCode calculation, since the original hashCode calculation does not include it. @marmbrus @cloud-fan Please review if the changes are good. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gatorsmile/spark hashCodeNamedExpression Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9761.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9761 ---- commit eb63f097df5595cebf09954bcd188a87c5ebfdb0 Author: gatorsmile <gatorsm...@gmail.com> Date: 2015-11-17T07:47:19Z follow-up: SPARK-8658 ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org