Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9761#issuecomment-157414057
@nongli I saw you have a related discussion with @chenghao-intel . The
failed test case was introduced in your PR
https://github.com/apache/spark/pull/9480. I am not sure the root reason why we
intentionally exclude `name` from `hashCode`, but the original `equals` include
`name`. It breaks a general principle of hashCode function design:
```
An objectâs hashCode method must take the same fields into account as its
equals method.
```
Based on my understanding, in a case-sensitive HiveContext, we still should
detect their differences when the case of `name` is different but the `exprId`
values are the same
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
