Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45285698
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
String, parent: ClassLoader
}
}
+ override def getResource(name: String): URL = {
+ parentLoader.getResource(name)
--- End diff --
@vanzin
I didn't see use case you mentioned but it could make sense.
In order to achieve, we have to implement findResource() and
findResources() for ExecutorClassLoader since ExecutorClassLoader cannot rely
on superclass (ClassLoader) to load class / resource.
It is easy to provide resource URL which points to origin scheme (http,
https, ftp, hdfs), but since I'm new to classloader, so I'm wondering it is
safe to return URL from findResource() and findResources() which doesn't point
to local file.
If it is not safe to return non local file as URL, what's recommended way
to do?
I can only think about downloading files to local temp directory per every
call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
