Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9812#discussion_r45286660
--- Diff:
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala ---
@@ -55,6 +57,14 @@ class ExecutorClassLoader(conf: SparkConf, classUri:
String, parent: ClassLoader
}
}
+ override def getResource(name: String): URL = {
+ parentLoader.getResource(name)
--- End diff --
> I'm wondering it is safe to return URL from findResource() and
findResources() which doesn't point to local file
That should be perfectly fine. That's how URLClassLoader works, after all.
The only potential odd thing would be `getResourceAsStream`, which returns an
`InputStream`, and my guess is if the JDK's `URL` class doesn't support the
protocol, would cause an error unless you overrode it here.
So perhaps it's too much to worry about and we can just assume that no one
will do that, and fix it if someone ever needs that feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
