Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9297#discussion_r46203496
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1332,9 +1337,13 @@ object SQLContext {
* Create a SQLListener then add it into SparkContext, and create an
SQLTab if there is SparkUI.
*/
private[sql] def createListenerAndUI(sc: SparkContext): SQLListener = {
- val listener = new SQLListener(sc.conf)
- sc.addSparkListener(listener)
- sc.ui.foreach(new SQLTab(listener, _))
- listener
+ if (sqlListener.get() == null) {
--- End diff --
Given that it's still legal to have multiple active SQLContexts in an
application (although this is not a good practice), isn't this a user-facing
behavioral change? If a user creates multiple SQLContexts, then they will now
only have one SQL tab in the UI and one SQLListener, which is different than
the old behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
