GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/10160
[SPARK-12158] [R] [SQL] Fix 'sample' functions that break R unit test cases
The existing sample functions miss the parameter 'seed', however, the
corresponding function interface in `generics` has such a parameter. Thus,
although the function caller calls the function with the 'seed', we are not
using it.
This could cause SparkR unit tests failed. For example, I hit it in another
PR:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47213/consoleFull
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark sampleR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10160
----
commit ec770100452ca1a869058e448b1b41c8efb810d9
Author: gatorsmile <gatorsm...@gmail.com>
Date: 2015-12-05T17:53:39Z
add sample functions with seeds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
