Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/10160#discussion_r46766732
--- Diff: R/pkg/R/DataFrame.R ---
@@ -677,25 +677,44 @@ setMethod("unique",
#' collect(sample(df, TRUE, 0.5))
#'}
setMethod("sample",
- # TODO : Figure out how to send integer as java.lang.Long to JVM
so
- # we can send seed as an argument through callJMethod
signature(x = "DataFrame", withReplacement = "logical",
- fraction = "numeric"),
- function(x, withReplacement, fraction) {
+ fraction = "numeric", seed = "missing"),
+ function(x, withReplacement, fraction, seed) {
if (fraction < 0.0) stop(cat("Negative fraction value:",
fraction))
sdf <- callJMethod(x@sdf, "sample", withReplacement, fraction)
dataFrame(sdf)
})
#' @rdname sample
+#' @name sample
+setMethod("sample",
+ # we can send seed as an argument through callJMethod
+ signature(x = "DataFrame", withReplacement = "logical",
+ fraction = "numeric", seed = "numeric"),
+ function(x, withReplacement, fraction, seed) {
+ if (fraction < 0.0) stop(cat("Negative fraction value:",
fraction))
+ sdf <- callJMethod(x@sdf, "sample", withReplacement, fraction,
as.integer(seed))
+ dataFrame(sdf)
+ })
+
+#' @rdname sample
#' @name sample_frac
setMethod("sample_frac",
signature(x = "DataFrame", withReplacement = "logical",
- fraction = "numeric"),
- function(x, withReplacement, fraction) {
+ fraction = "numeric", seed = "missing"),
+ function(x, withReplacement, fraction, seed) {
sample(x, withReplacement, fraction)
})
+#' @rdname sample
+#' @name sample_frac
+setMethod("sample_frac",
+ signature(x = "DataFrame", withReplacement = "logical",
+ fraction = "numeric", seed = "numeric"),
+ function(x, withReplacement, fraction, seed) {
+ sample(x, withReplacement, fraction, as.integer(seed))
--- End diff --
same here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
