Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10130#discussion_r47397253
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -394,6 +394,15 @@ class DataFrame private[sql](
def show(numRows: Int, truncate: Boolean): Unit =
println(showString(numRows, truncate))
// scalastyle:on println
+ def show(numRows: Int, truncate: Boolean, outputStream: OutputStream):
Unit = {
+ val writer = new OutputStreamWriter(outputStream, "UTF-8")
+ writer.write(showString(numRows, truncate))
+ }
+
+ def show(numRows: Int, truncate: Boolean, writer: Writer): Unit = {
--- End diff --
these signatures are really clunky and I don't think we want it. Also the
string is already composed so it's not like we're streaming things to the
writer anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
