Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10256#discussion_r47545169
  
    --- Diff: pom.xml ---
    @@ -169,7 +169,7 @@
         <jline.version>${scala.version}</jline.version>
         <jline.groupid>org.scala-lang</jline.groupid>
         <codehaus.jackson.version>1.9.13</codehaus.jackson.version>
    -    <fasterxml.jackson.version>2.4.4</fasterxml.jackson.version>
    +    <fasterxml.jackson.version>2.5.3</fasterxml.jackson.version>
    --- End diff --
    
    @holdenk Unfortunately the tests that actually mattered didn't run, they 
were ignored :(
    ```
    [info] WithAggregationKinesisStreamSuite:
    [info] - KinesisUtils API (202 milliseconds)
    [info] - RDD generation (24 milliseconds)
    [info] - basic operation [enable by setting env var ENABLE_KINESIS_TESTS=1] 
!!! IGNORED !!!
    [info] - custom message handling [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - failure recovery [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Prepare KinesisTestUtils [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] WithoutAggregationKinesisStreamSuite:
    [info] - KinesisUtils API (5 milliseconds)
    [info] - RDD generation (6 milliseconds)
    [info] - basic operation [enable by setting env var ENABLE_KINESIS_TESTS=1] 
!!! IGNORED !!!
    [info] - custom message handling [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - failure recovery [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Prepare KinesisTestUtils [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] WithAggregationKinesisBackedBlockRDDSuite:
    [info] - Basic reading from Kinesis [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available in both block manager and Kinesis [enable by 
setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available only in block manager, not in Kinesis [enable 
by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available only in Kinesis, not in block manager [enable 
by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available partially in block manager, rest in Kinesis 
[enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Test isBlockValid skips block fetching from block manager [enable 
by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Test whether RDD is valid after removing blocks from block anager 
[enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] WithoutAggregationKinesisBackedBlockRDDSuite:
    [info] - Basic reading from Kinesis [enable by setting env var 
ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available in both block manager and Kinesis [enable by 
setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available only in block manager, not in Kinesis [enable 
by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available only in Kinesis, not in block manager [enable 
by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Read data available partially in block manager, rest in Kinesis 
[enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Test isBlockValid skips block fetching from block manager [enable 
by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    [info] - Test whether RDD is valid after removing blocks from block anager 
[enable by setting env var ENABLE_KINESIS_TESTS=1] !!! IGNORED !!!
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to