Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/10341#issuecomment-166254649
Oh, actually I didn't meant that you should use string comparison to test
all ORC filters. It's perfectly OK to use `PredicateLeaf` for leaf predicates,
and only use string comparison to test for `AND`/`OR`/`NOT`. Since there are
not too many cases for the latter, you probably don't need to bother using
those string templates.
The only reason that I suggested using string comparison here is that ORC
doesn't expose necessary interfaces similar to `PredicateLeaf` for composed
predicates. And it should only be used as a workaround rather than a general
rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
