Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/10341#issuecomment-166516260
In the commits above, I added tests for logical operators separately.
Although it does not check all the combinations across types with logical
operators, I think this would be okay because the basic comparison operators
are being tested across types.
Could we add some tests for logical operators across types later if they
are necessary in a way? I do not want to make tests hacky clunky.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
