Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10502#discussion_r48593890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -288,20 +293,28 @@ private[sql] class ParquetRelation(
}
}
+ override def unhandledFilters(filters: Array[Filter]): Array[Filter] = {
+ // The unsafe row RecordReader does not support row by row filtering
so for this case
+ // it should wrap this with Spark-side filtering.
+ val enableUnsafeRowParquetReader =
+
sqlContext.getConf(SQLConf.PARQUET_UNSAFE_ROW_RECORD_READER_ENABLED.key).toBoolean
--- End diff --
Hm.. I think we can implement this for now and then simply change the
condition when `UnsafeRowParquetRecordReader` supports filtering row by row.
The option for Parquet filter push down was also false by default but it
was implemented. I don't think a default value can deicde if a feature should
be implemented or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
