Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/10502#discussion_r48603240
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -208,11 +210,30 @@ private[sql] object ParquetFilters {
}
/**
+ * Return referenced columns in [[sources.Filter]].
+ */
+ def referencedColumns(schema: StructType, predicate: sources.Filter):
Array[String] = {
+ val dataTypeOf = schema.map(f => f.name -> f.dataType).toMap
+ val referencedColumns = ArrayBuffer.empty[String]
+ def getDataTypeOf(name: String): DataType = {
+ referencedColumns += name
+ dataTypeOf(name)
+ }
+ createParquetFilter(getDataTypeOf, predicate)
--- End diff --
For me I think I would not be sure why `createFilter` retuens filters with
referenced columns. I see `OrcFilters.createFilter` returns only filters and I
do not think `Parquet.createFilter` returning multiple objects is eazy to read.
If you think we don't have to run the function twice and the
implementation is hacky, please suggest possible implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
