Github user guoxu1231 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10464#discussion_r48676000
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/SocketInputDStream.scala
---
@@ -52,46 +52,60 @@ class SocketReceiver[T: ClassTag](
storageLevel: StorageLevel
) extends Receiver[T](storageLevel) with Logging {
+ private var socket: Socket = _
+
def onStart() {
- // Start the thread that receives data over a connection
- new Thread("Socket Receiver") {
- setDaemon(true)
- override def run() { receive() }
- }.start()
+
+ try {
+ logInfo(s"Connecting to $host:$port")
+ socket = new Socket(host, port)
+ logInfo(s"Connected to $host:$port")
+
+ // Start the thread that receives data over a connection
+ new Thread("Socket Receiver") {
+ setDaemon(true)
+ override def run() { receive() }
+ }.start()
+ } catch {
+ case e: ConnectException =>
+ restart(s"Error connecting to $host:$port", e)
+ case NonFatal(e) =>
--- End diff --
"This is now in the wrong place. It was correct where it was."
Sorry, I didn't catch this comment. I thought you means the "new Thread"
block so I moved the "new Thead" block outside the try/catch block, It will
looks like cause NPE. could you give more information about which block is now
in the wrong block?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
