Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10464#discussion_r48678510 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/SocketInputDStream.scala --- @@ -51,29 +51,44 @@ class SocketReceiver[T: ClassTag]( storageLevel: StorageLevel ) extends Receiver[T](storageLevel) with Logging { + private var socket: Socket = _ + def onStart() { - // Start the thread that receives data over a connection - new Thread("Socket Receiver") { - setDaemon(true) - override def run() { receive() } - }.start() + try { + logInfo(s"Connecting to $host:$port") + socket = new Socket(host, port) + logInfo(s"Connected to $host:$port") + } catch { + case NonFatal(e) => --- End diff -- Hm, I suppose now you're restarting here on any non-fatal error in connecting, not just `ConnectException`. Maybe that's OK. It's simpler to return here rather than then have to check if the socket initialized. Also the info logs seem like they don't belong in the try-catch; they can't fail.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org