Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48919495
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -129,23 +129,39 @@ object UnresolvedAttribute {
nameParts.toSeq
}
}
+trait UnresolvedFunctionLike extends Expression {
--- End diff --
I'd remove this trait since it is only used twice. The overhead of having
an abstraction doesn't seem worth it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
