Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r48931248
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -153,32 +154,45 @@ object SetOperationPushDown extends Rule[LogicalPlan]
with PredicateHelper {
}
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
- // Push down filter into union
- case Filter(condition, u @ Union(left, right)) =>
- val (deterministic, nondeterministic) =
partitionByDeterministic(condition)
- val rewrites = buildRewrites(u)
- Filter(nondeterministic,
- Union(
- Filter(deterministic, left),
- Filter(pushToRight(deterministic, rewrites), right)
- )
- )
// Push down deterministic projection through UNION ALL
- case p @ Project(projectList, u @ Union(left, right)) =>
+ case p @ Project(projectList, Union(children)) =>
+ assert(children.nonEmpty)
if (projectList.forall(_.deterministic)) {
- val rewrites = buildRewrites(u)
+ val newFirstChild = Project(projectList, children.head)
+ val newOtherChildren = children.tail.map {
--- End diff --
put child on the previous line and remove one level of indentation for the
closure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
