Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r48931365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -123,6 +115,35 @@ case class Except(left: LogicalPlan, right:
LogicalPlan) extends SetOperation(le
override def output: Seq[Attribute] = left.output
}
+/** Factory for constructing new `Unions` nodes. */
+object Union {
+ def apply(left: LogicalPlan, right: LogicalPlan): Union = {
+ Union (left :: right :: Nil)
+ }
+}
+
+case class Union(children: Seq[LogicalPlan]) extends LogicalPlan {
+
+ override def output: Seq[Attribute] = {
+ children.tail.foldLeft(children.head.output) { case (currentOutput,
child) =>
--- End diff --
I'd also add some comment here explaining what's going on. at a high level,
you are just updating nullability right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
