Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10583#discussion_r48951342
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -451,6 +452,19 @@ private[spark] object SQLConf {
         doc = "When true, we could use `datasource`.`path` as table in SQL 
query"
       )
     
    +  val PARSER_SUPPORT_QUOTEDID = 
booleanConf("spark.sql.parser.supportQuotedIdentifiers",
    +    defaultValue = Some(true),
    +    isPublic = false,
    +    doc = "Whether to use quoted identifier.\n  false: default(past) 
behavior. Implies only" +
    +      "alphaNumeric and underscore are valid characters in identifiers.\n" 
+
    +      "  true: implies column names can contain any character.")
    +
    +  val PARSER_SUPPORT_SQL11_RESERVED_KEYWORDS = booleanConf(
    +    "spark.sql.parser.supportSQL11ReservedKeywords",
    +    defaultValue = Some(false),
    --- End diff --
    
    Some of our out-dated Hive Compatibility Tests are using SQL11 reserved 
keywords as identifiers. We should first fix those before we can set this flag 
to true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to