Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r48987615
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -608,7 +609,9 @@ class Dataset[T] private[sql](
* duplicate items. As such, it is analogous to `UNION ALL` in SQL.
* @since 1.6.0
*/
- def union(other: Dataset[T]): Dataset[T] = withPlan[T](other)(Union)
+ def union(other: Dataset[T]): Dataset[T] = withPlan[T](other){ (left,
right) =>
--- End diff --
We talked about this and decided that it would be way too confusing to
require users to say `unionAll` or have `union` do a distinct (because RDDs,
scalding, flink etc all use union as a combine). I'd view `unionAll` as an
alias for SQL people, and if we were going to get rid of one it would probably
be that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
