Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10570#discussion_r49018866
--- Diff:
mllib/src/test/java/org/apache/spark/mllib/regression/JavaIsotonicRegressionSuite.java
---
@@ -81,10 +81,10 @@ public void testIsotonicRegressionPredictionsJavaRDD() {
JavaDoubleRDD testRDD = sc.parallelizeDoubles(Arrays.asList(0.0, 1.0,
9.5, 12.0, 13.0));
List<Double> predictions = model.predict(testRDD).collect();
- Assert.assertTrue(predictions.get(0) == 1d);
- Assert.assertTrue(predictions.get(1) == 1d);
- Assert.assertTrue(predictions.get(2) == 10d);
- Assert.assertTrue(predictions.get(3) == 12d);
- Assert.assertTrue(predictions.get(4) == 12d);
+ Assert.assertEquals(1.0, predictions.get(0).doubleValue(), 1.0e-14);
--- End diff --
No it's still asserting equality to 1.0; the expected value comes first so
that's where 1.0 went (changed from the more obscure 1d). I added the epsilon
at the end since the version without it is deprecated. (And I just made up a
tiny epsilon.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
