Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10403#discussion_r49266372
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
@@ -41,6 +41,26 @@ private case object MySQLDialect extends JdbcDialect {
override def quoteIdentifier(colName: String): String = {
s"`$colName`"
}
+
+ override def parseTableName(tableName: String): String = {
+ val tableName1 = tableName.replace("\"", "").replace("\'", "")
+ if (tableName1.contains(".")) {
+ val tableNameList = tableName1.split('.')
+ tableNameList.foldLeft("") { (leftStr, rightStr) =>
--- End diff --
Also, can you add unit tests for this function? _Not_ end-to-end tests, but
a test which exercises this method in isolation, similar to the ones that I
have in `spark-redshift`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
