Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10403#discussion_r49266387
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala ---
@@ -41,6 +41,26 @@ private case object MySQLDialect extends JdbcDialect {
override def quoteIdentifier(colName: String): String = {
s"`$colName`"
}
+
+ override def parseTableName(tableName: String): String = {
+ val tableName1 = tableName.replace("\"", "").replace("\'", "")
--- End diff --
Why is it correct to just drop quotes here? What if the schema name also
contains a dot? Don't you need to keep track of quotes during the string
processing in order to figure out where the schema name ends and the table name
begins?
Note that both the schema and table names could contain dots (AFAIK, if not
please comment with a citation explaining why not), so simply grabbing the last
component after a dot might not be correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
