Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49630313 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationPushDownSuite.scala --- @@ -30,42 +30,67 @@ class SetOperationPushDownSuite extends PlanTest { Batch("Subqueries", Once, EliminateSubQueries) :: Batch("Union Pushdown", Once, + CombineUnions, SetOperationPushDown, SimplifyFilters) :: Nil } val testRelation = LocalRelation('a.int, 'b.int, 'c.int) val testRelation2 = LocalRelation('d.int, 'e.int, 'f.int) - val testUnion = Union(testRelation, testRelation2) + val testRelation3 = LocalRelation('g.int, 'h.int, 'i.int) + val testUnion = Union(testRelation :: testRelation2 :: testRelation3 :: Nil) val testIntersect = Intersect(testRelation, testRelation2) val testExcept = Except(testRelation, testRelation2) - test("union/intersect/except: filter to each side") { - val unionQuery = testUnion.where('a === 1) + test("union: combine unions into one unions") { --- End diff -- oh, maybe just remove this test suite to `SetOperationSuite`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org