Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10577#discussion_r49632415
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -170,17 +173,27 @@ object ExtractFiltersAndInnerJoins extends
PredicateHelper {
}
}
+
/**
* A pattern that collects all adjacent unions and returns their children
as a Seq.
*/
object Unions {
def unapply(plan: LogicalPlan): Option[Seq[LogicalPlan]] = plan match {
- case u: Union => Some(collectUnionChildren(u))
+ case u: Union => Some(collectUnionChildren(ArrayBuffer(u),
Seq.empty[LogicalPlan]))
case _ => None
}
- private def collectUnionChildren(plan: LogicalPlan): Seq[LogicalPlan] =
plan match {
- case Union(l, r) => collectUnionChildren(l) ++ collectUnionChildren(r)
- case other => other :: Nil
+ @tailrec
+ private def collectUnionChildren(
+ plan: ArrayBuffer[LogicalPlan],
--- End diff --
I think that's fine. Actually most of the time writing functional code for
the sake of writing functional code is a bad idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
