Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172003851
Regarding the question on waiting strategies, I don't think polling is that
bad. It's localized and simple to reason about, and I suppose `stop` should be
synchronous. @tnachen's suggestion is fine, but unless I miss something,
there's no significant advantage, but there's a potential deadlock situation
and more complicated reasoning (`notify` is called from a callback, so looking
at `stop` is no longer enough to understand what's going on).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
