Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10319#issuecomment-172041940
I think that either case just looking at stop isn't enough since we are
relying on the callback to empty the executors map for us to exit the loop
before the timeout, so either way i thought it's just explicit and don't have
to busy wait for no reason. I'm fine with a while loop here, I might increase
the sleep time since we are waiting on messages to be sent back from executors
to driver and I would think checking every 100ms probably enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
