Github user iyounus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10702#discussion_r49941742
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -219,33 +219,41 @@ class LinearRegression @Since("1.3.0")
(@Since("1.3.0") override val uid: String
}
val yMean = ySummarizer.mean(0)
- val yStd = math.sqrt(ySummarizer.variance(0))
+ var yStd = math.sqrt(ySummarizer.variance(0))
--- End diff --
@srowen I agree with these comments. I'm working on `WeightedLeastSquares`
(https://github.com/apache/spark/pull/10274), and there are some commonalities
between these two issues. Once I've completed all tests for
`WeightedLeastSquares`, I'll compete this issue.
Some of the tests for `LinearRegression` use both `normal` and `l-bfgs`
solvers. It would nice if `WeightedLeastSquares` issue is merged so that I can
write tests in similar way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
