Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10805#discussion_r50074461
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVParameters.scala
---
@@ -71,6 +71,8 @@ private[sql] case class CSVParameters(parameters:
Map[String, String]) extends L
val nullValue = parameters.getOrElse("nullValue", "")
+ val codec = parameters.getOrElse("compression",
parameters.getOrElse("codec", null))
--- End diff --
the other thing is that i'd create short-form names for the common options,
e.g. "gzip" should become GzipCodec. You'd need to look into what the commonly
supported formats are and come up with their short names. We should also make
sure this is case insensitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
