Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10805#discussion_r50081941
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVParameters.scala
---
@@ -73,6 +82,12 @@ private[sql] case class CSVParameters(@transient
parameters: Map[String, String]
val nullValue = parameters.getOrElse("nullValue", "")
+ val compressionCodec: String = {
+ val maybeCodecName =
+ Option(parameters.getOrElse("compression",
parameters.getOrElse("codec", null)))
+
maybeCodecName.map(_.toLowerCase).map(shortCompressionCodecNames).orNull
--- End diff --
this logic is becoming confusing with so many level of nesting. we should
rewrite it (even with more loc) to make it more readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
