Github user napsternxg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10836#discussion_r50184164
  
    --- Diff: R/install-dev.sh ---
    @@ -35,12 +35,19 @@ LIB_DIR="$FWDIR/lib"
     mkdir -p $LIB_DIR
     
     pushd $FWDIR > /dev/null
    +if [ ! -z "$1" ]
    +  then
    +    R_HOME="$1/bin"
    +   else
    +    R_HOME="$(dirname $(which R))"
    --- End diff --
    
    In R there there is usually no `R_HOME` like there is in python so this 
might confuse users.  We should use the default R when the variable is not 
passed. 
    
    Or I can use a variable like `SPARK_R_HOME` which specifies the R home 
directory ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to